Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin Farsi translation (alternative translation to #73) #74

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mazdakdev
Copy link

@mazdakdev mazdakdev commented Apr 4, 2024

What does this PR do?

  • Translated index.md and created a folder for Farsi as mentioned.
  • Translated fine_tuning_code_llm_on_single_gpu

This pull request is basically the same as with the pr #73 with an extra notebook that has been translated and a slightly more accurate translation of index.md compared to #73.

Note that there is a issue with RTL texts in Jupyter Notebooks. (FIXED)

Fixes # (issue)

Who can review?

@MKhalusova

@mazdakdev mazdakdev changed the title Begin Farsi translation (better translation: #72) Begin Farsi translation (better translation: #73) Apr 4, 2024
@mazdakdev mazdakdev changed the title Begin Farsi translation (better translation: #73) Begin Farsi translation (alternative translation to #73) Apr 4, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mazdakdev
Copy link
Author

@merveenoyan @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you delete the other fine_tuning_code_llm_on_single_gpu.ipynb file that is not inside notebooks/fa?

Also, can you find another Farsi speaker or reader to review your translation for accuracy? The forums or Discord could be a good starting point to look for potential collaborators 🤗

@mazdakdev
Copy link
Author

@stevhliu Done!
Sure! @Alirezaaraby could you please review this PR?

Also worth mentioning, This PR only initializes the Persian translation, and may contain some technical or translation errors. We welcome Persian-speaking contributors to help refine the translation in the future.

@mazdakdev
Copy link
Author

The English source file was accidentally deleted in previous commits, causing the workflow to fail.
reverted the file to its previous state.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@mazdakdev
Copy link
Author

Hey @MrzEsma !
If it's possible for you, could you please review this PR in terms of accuracy?

@Alirezaaraby
Copy link

Alirezaaraby commented Jul 30, 2024

Quote reply

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants